Skip to content

Remove JvmIrDeserializer#5693

Merged
KotlinBuild merged 4 commits intomasterfrom
rr/kylchik/drop-jvm-ir-deserialize
Mar 4, 2026
Merged

Remove JvmIrDeserializer#5693
KotlinBuild merged 4 commits intomasterfrom
rr/kylchik/drop-jvm-ir-deserialize

Conversation

@ivandev0
Copy link
Contributor

This is a continuation of removing IR serialization feature from JVM. This time I removed IR deserialization.

@kotlin-safe-merge
Copy link

kotlin-safe-merge bot commented Feb 18, 2026

Code Owners

Rule Owners Approval
/​analysis/​ kotlin-analysis-api
/​compiler/​cli/​, /​compiler/​fir/​, /​compiler/​tests-​common-​new/​, /​core/​compiler.​common.​jvm/​, /​core/​deserialization.​common.​jvm/​ kotlin-frontend
/​compiler/​cli/​cli-​native-​klib/​ kotlin-common-backend, kotlin-frontend
/​compiler/​incremental-​compilation-​impl/​ build-tools-api, kotlin-build-tools
/​compiler/​ir/​backend.​jvm/​, /​compiler/​ir/​ir.​psi2ir/​, /​compiler/​ir/​serialization.​jvm/​ kotlin-jvm
/​compiler/​ir/​ir.​tree/​ kotlin-common-backend
/​compiler/​tests-​compiler-​utils/​ kotlin-compiler
/​plugins/​compose/​ @ShikaSD, @andrewbailey, @bentrengrove, @chuckjaz, @derekxu16

@ivandev0 ivandev0 requested a review from udalov February 18, 2026 13:46
udalov
udalov previously approved these changes Feb 18, 2026
@ligee
Copy link
Contributor

ligee commented Feb 18, 2026

@ivandev0, it would be very helpful to place a reference to the reasons for removing IR (de)serialization into the commit messages, a link to the corresponding YT issue, or just a few words. I have no active context about it, so it's difficult to make a meaningful approval. But even if I did, such a reference would still benefit the future maintenance.

@ivandev0
Copy link
Contributor Author

@ivandev0, it would be very helpful to place a reference to the reasons for removing IR (de)serialization into the commit messages, a link to the corresponding YT issue, or just a few words. I have no active context about it, so it's difficult to make a meaningful approval. But even if I did, such a reference would still benefit the future maintenance.

Yes, sorry. I was a little bit lazy here. We don't have any tickets. Serialization of IR for JVM was an experimental feature for a long time, and the only known usage was at Google side. We finally got a green light to drop it completely.

As for the reason why we drop it, again, no tickets. The best thing I can give you is this comment.

Right now I am considering this as tech dept and have little to write into the commit message. I can create a ticket just for the sake of it, but I personally don't know the benefit of such a ticket.

@KotlinBuild KotlinBuild force-pushed the rr/kylchik/drop-jvm-ir-deserialize branch from 587b90e to e2f780d Compare February 19, 2026 10:12
ligee
ligee previously approved these changes Feb 19, 2026
@Tapchicoma Tapchicoma requested review from Tapchicoma and removed request for AYastrebov February 27, 2026 14:50
Tapchicoma
Tapchicoma previously approved these changes Feb 27, 2026
@KotlinBuild KotlinBuild force-pushed the rr/kylchik/drop-jvm-ir-deserialize branch from e2f780d to 564fece Compare February 27, 2026 19:39
@kotlin-safe-merge kotlin-safe-merge bot dismissed stale reviews from Tapchicoma and ligee February 27, 2026 19:39

New changes affect files owned by this reviewer. Re-review required.

@ivandev0
Copy link
Contributor Author

Did a rebase on fresh master

@KotlinBuild KotlinBuild force-pushed the rr/kylchik/drop-jvm-ir-deserialize branch from 564fece to 35987ae Compare February 27, 2026 21:27
@kotlin-safe-merge kotlin-safe-merge bot dismissed udalov’s stale review February 27, 2026 21:27

New changes affect files owned by this reviewer. Re-review required.

@ivandev0 ivandev0 requested a review from ligee March 3, 2026 16:50
@ivandev0
Copy link
Contributor Author

ivandev0 commented Mar 4, 2026

/test-public

@ivandev0
Copy link
Contributor Author

ivandev0 commented Mar 4, 2026

/dry-run

@KotlinBuild
Copy link

THIS IS A DRY RUN

Quality gate is triggered at https://buildserver.labs.intellij.net/build/892732140 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5693/safe-merge
Commit: 21be95e

@KotlinBuild
Copy link

Quality gate finished successfully.

@ivandev0
Copy link
Contributor Author

ivandev0 commented Mar 4, 2026

/safe-merge

@KotlinBuild
Copy link

Quality gate is triggered at https://buildserver.labs.intellij.net/build/892992453 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5693/safe-merge
Commit: 8fb16cf

@KotlinBuild
Copy link

Quality gate finished successfully.

@KotlinBuild KotlinBuild merged commit f59d341 into master Mar 4, 2026
2 checks passed
@KotlinBuild KotlinBuild deleted the rr/kylchik/drop-jvm-ir-deserialize branch March 4, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants